This is a *proposed* change to address the issue that the launch requ… #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est could come after the configurationDone request (microsoft/vscode#3548). This commit "should" allow the messages to come in either order and still work. However, it needs a good review. BTW it appears all the messages are processed on the same thread (or maybe that was coincidence). If that is the case then perhaps the lock is not needed. Still it is a fairly lightweight lock - one bool check and an assignment.
| { | ||
| // Ensure that only the second message between launch and | ||
| // configurationDone requests, actually launches the script. | ||
| lock (syncLock) |
There was a problem hiding this comment.
Theoretically you shouldn't need a lock for this since all requests are handled serially by the MessageReader (a SynchronizationContext handles reads in a queue). Did you run into a case where there was a race condition or are you just being cautious?
There was a problem hiding this comment.
No. Was just being overly cautious. I'll drop the locks.
There was a problem hiding this comment.
No problem! There can be some more subtle behavior with async methods that could require locking but we can discuss that another time ;)
|
Yeah, sorry I didn't follow up on that! I'll merge it. |
daviwil
added a commit
that referenced
this pull request
Mar 3, 2016
…ling This is a *proposed* change to address the issue that the launch requ…
|
No problemo. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…est could come after the configurationDone request (microsoft/vscode#3548).
This commit "should" allow the messages to come in either order and still work. *However, it needs a good review. * BTW it appears all the messages are processed on the same thread (or maybe that was coincidence). If that is the case then perhaps the lock is not needed. Still it is a fairly lightweight lock - one bool check and an assignment.